Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): can't work default values in OnPush mode #2364

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2318,#2085

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2364 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
+ Coverage   95.83%   95.84%   +<.01%     
==========================================
  Files         485      485              
  Lines       12286    12287       +1     
  Branches     1670     1670              
==========================================
+ Hits        11774    11776       +2     
+ Misses        151      150       -1     
  Partials      361      361
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 98.23% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea1d05...3405282. Read the comment docs.

@vthinkxie vthinkxie merged commit 04cf7aa into NG-ZORRO:master Oct 26, 2018
@hsuanxyz hsuanxyz deleted the tree-select/fix-onpush-2 branch January 8, 2019 12:11
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants