Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:core,root): ensure compatibility to v4 #233

Merged
merged 1 commit into from
Sep 6, 2017
Merged

fix(module:core,root): ensure compatibility to v4 #233

merged 1 commit into from
Sep 6, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Sep 6, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes #69

What is the new behavior?

DOCUMENT in @angular/common was introduced in 4.3.0-rc.0, as we documented the compatibility for ~4.0.0, it should not be used in production codes. (Won't matter for showcase or documentation)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Need to be revisited after v5 being the minimal requirements.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 33.624% when pulling ba08f77 on trotyl:fix-compat-v4 into 5f11664 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 2b5c083 into NG-ZORRO:master Sep 6, 2017
@vthinkxie
Copy link
Member

it seems that there existsimport { DOCUMENT } from '@angular/common' in other components and tests, should it be fix in an other pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

模块引入报错
3 participants