Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:menu): support unfolds/folds & add demo and api docs #225

Merged
merged 2 commits into from
Sep 9, 2017

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Sep 5, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #206

What is the new behavior?

menu

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.204% when pulling 5a29c67 on HsuanXyz:feature-menu-collapsed into 74b2506 on NG-ZORRO:master.

@@ -181,6 +181,10 @@
}
}

&-vertical {
Copy link
Member

@vthinkxie vthinkxie Sep 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better not change any style file, if must, please add custom style in patch.less file other than the index.less since it will be sync with ant design react.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better not change any style file, if must, please add custom style in patch.less file other than the index.less since it will be sync with ant design react.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.973% when pulling 8224d0e on HsuanXyz:feature-menu-collapsed into 74b2506 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 23b73bb into NG-ZORRO:master Sep 9, 2017
@hsuanxyz hsuanxyz deleted the feature-menu-collapsed branch October 17, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants