fix(module:list): fix does not trigger change detection correctly when from empty array to data array #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade laster version
latest version
upgrade latest
…n from empty array to data array
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
==========================================
- Coverage 95.96% 95.96% -0.01%
==========================================
Files 482 482
Lines 11965 11956 -9
Branches 1594 1594
==========================================
- Hits 11482 11473 -9
Misses 134 134
Partials 349 349
Continue to review full report at Codecov.
|
wilsoncook
requested changes
Oct 6, 2018
components/list/nz-list.component.ts
Outdated
| this._setClassMap(); | ||
| // Delayed detection refresh limited by nz-spin (issesus (#11280)[https://github.com/angular/material2/issues/11280) ) |
There was a problem hiding this comment.
"issesus" misspelled, fixed it to allow merge
There was a problem hiding this comment.
And "[https://github.com/angular/components/issues/11280)" tobe "[https://github.com/angular/components/issues/11280]"
wilsoncook
requested changes
Oct 6, 2018
components/list/nz-list.component.ts
Outdated
| this._setClassMap(); | ||
| // Delayed detection refresh limited by nz-spin (issesus (#11280)[https://github.com/angular/material2/issues/11280) ) |
There was a problem hiding this comment.
And "[https://github.com/angular/components/issues/11280)" tobe "[https://github.com/angular/components/issues/11280]"
|
Good job @cipchk |
wilsoncook
approved these changes
Oct 6, 2018
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…n from empty array to data array (NG-ZORRO#2199) * fix(module:list): fix does not trigger change detection correctly when from empty array to data array * fix document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1819
What is the new behavior?
Does this PR introduce a breaking change?
Other information