Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): fix search box exception when Chinese search #8324

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

EnochGao
Copy link
Contributor

fix bug: #8165

Copy link

zorro-bot bot commented Dec 26, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c0dd00) 91.72% compared to head (403fb75) 91.74%.
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8324      +/-   ##
==========================================
+ Coverage   91.72%   91.74%   +0.02%     
==========================================
  Files         520      520              
  Lines       18010    18018       +8     
  Branches     2838     2838              
==========================================
+ Hits        16519    16531      +12     
+ Misses       1188     1184       -4     
  Partials      303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EnochGao thanks a lot fot this PR, could you please provide the tests for the code added :)

Thanks in advance :)

@EnochGao
Copy link
Contributor Author

Hi @EnochGao thanks a lot fot this PR, could you please provide the tests for the code added :)

Thanks in advance :)

Kindly verify it

@Nicoss54 Nicoss54 added PR: partially-approved and removed PR: reviewed-changes-requested PR: need-test Test is necessary for code changes. labels Jan 17, 2024
@Nicoss54
Copy link
Collaborator

LGTM

@OriginRing OriginRing merged commit aacd62b into NG-ZORRO:master Jan 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants