Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markAsDirty and markAsTouched does not add classes correctly #3865

Closed
goknsh opened this issue Jul 26, 2019 · 0 comments · Fixed by #3868
Closed

markAsDirty and markAsTouched does not add classes correctly #3865

goknsh opened this issue Jul 26, 2019 · 0 comments · Fixed by #3868
Assignees
@vthinkxie
Labels
🐛 Bug Component: Form

Comments

@goknsh
Copy link

goknsh commented Jul 26, 2019

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-utad4l

Steps to reproduce

  1. Create a form in constructor
  2. Mark a field as touched or dirty after form is created

What is expected?

ant-form-item-with-help class is added to respective nz-form-item when markAsDirty() or markAsTouched() is called.

What is actually happening?

ant-form-item-with-help class is not added to respective nz-form-item when markAsDirty() or markAsTouched() is called.

Environment Info
ng-zorro-antd 8.1.0
Browser Firefox 69.0
@goknsh goknsh changed the title markAsDirty and markAsTouched do not add classes correctly markAsDirty and markAsTouched does not add classes correctly Jul 26, 2019
@vthinkxie vthinkxie mentioned this issue Jul 26, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Jul 26, 2019
@vthinkxie
fix(module:form): fix form feedback error when init with tips (#3868)
7c0aa51 
close #3865
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
fix(module:form): fix form feedback error when init with tips (NG-ZOR…
e408b51 
…RO#3868)

close NG-ZORRO#3865
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:form): fix form feedback error when init with tips (NG-ZOR…
b4f7bfc 
…RO#3868)

close NG-ZORRO#3865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
🐛 Bug Component: Form
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:form): fix form feedback error when init with tips
3 participants
@vthinkxie @wzhudev @goknsh