Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling dropdown backdrop works only for the first time and not letting close the dropdown but by selecting an item #3835

Closed
amiram opened this issue Jul 21, 2019 · 3 comments
Assignees

Comments

@amiram
Copy link

amiram commented Jul 21, 2019

Reproduction link

https://stackblitz.com/edit/angular-q8zww2

Steps to reproduce

Add a dropdown with trigger=click and nzBackdrop=false
Add a button beside that will do something on hover.
Open the dropdown menu and hover on the button - hover effect works. Click on the dropdown button - menu not closed.
Close the menu by selecting an item from it.
Open the dropdown menu and hover on the button - hover effect doesn't work. Click on the dropdown button - menu is closed.

What is expected?

Hover effect of elements beside always should work. Menu should always be closed when clicking on the dropdown button.

What is actually happening?

Hover effect works only in the first open.
Menu is not closed when clicking on the dropdown in the first open, only in the next opens.

Environment Info
ng-zorro-antd 8.1.0
Browser Chrome 75
@lppedd
Copy link
Contributor

lppedd commented Jul 21, 2019

Hi @amiram, this is totally my fault, coming from PR #3769.
I have fixed this on #3831, you can read the explanation there.

I have just added additional tests to prevent this happening again, also, I use it on my own work projects, so I had to fix it immediately.
Again, sorry!

@amiram
Copy link
Author

amiram commented Jul 22, 2019

Thanks a lot for the fix. We all do mistakes all the time.

@lppedd
Copy link
Contributor

lppedd commented Jul 22, 2019

@amiram It's nothing. Lets wait for them to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants