Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing loading spinner icon for nz-table #3008

Closed
darshanrampatel opened this issue Mar 1, 2019 · 0 comments · Fixed by #3299
Closed

Allow changing loading spinner icon for nz-table #3008

darshanrampatel opened this issue Mar 1, 2019 · 0 comments · Fixed by #3299
Assignees
@vthinkxie
Labels
Component: Table 🌈 Feature Request

Comments

@darshanrampatel
Copy link
Contributor

What problem does this feature solve?

When using the nzLoading property on an nz-table, the spinner is the default one. I would like to be able to change this to use a custom icon.

What does the proposed API look like?

New property on nz-table:

[nzLoadingIndicator]

of type

TemplateRef<void>

For example,

<ng-template #indicatorTemplate>
    <i nz-icon type="loading" style="font-size: 24px;"></i>
</ng-template>

the nz-spin in nz-table that needs to use this template as [nzIndicator]
@vthinkxie vthinkxie mentioned this issue Apr 18, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Apr 18, 2019
@vthinkxie
feat(module:table): support nzLoadingIndicator (#3299)
1f339b3 
close #3008
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@vthinkxie @andrew-yangy
feat(module:table): support nzLoadingIndicator (NG-ZORRO#3299)
a15a0f6 
close NG-ZORRO#3008
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
feat(module:table): support nzLoadingIndicator (NG-ZORRO#3299)
d555304 
close NG-ZORRO#3008
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
feat(module:table): support nzLoadingIndicator (NG-ZORRO#3299)
e599c6f 
close NG-ZORRO#3008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
Component: Table 🌈 Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(module:table): support nzLoadingIndicator
2 participants
@vthinkxie @darshanrampatel