Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I often get a big tab through invisible placeholders #475

Closed
supermem99 opened this issue Jan 4, 2022 · 16 comments
Closed

I often get a big tab through invisible placeholders #475

supermem99 opened this issue Jan 4, 2022 · 16 comments
Labels
On hold: Unable to reproduce Provided steps were not enough to reproduce the issue Type: Bug Plugin is not working as described on the wiki
Milestone

Comments

@supermem99
Copy link

supermem99 commented Jan 4, 2022

Server version
1.18.1 Paper

Plugin version ("latest" is not a version)
3.0.1

Describe the bug
Sometimes when I join my Server, the placeholder refreshes and I get a long tab...

How to reproduce

  1. Have more placeholder in your tab like in my example:
    tabprefix: '%premiumvanish_isvanished%&8[%animation:owner_prefix%&8] {#ca191e}%reloadedutils_blinken%'
  2. Join to your server
  3. get this tab
    Screenshot_1

Expected behavior
it simply should be a smaller tab.

Actual behavior
Have a big tab

Additional info (errors, screenshots, ...)

@NEZNAMY
Copy link
Owner

NEZNAMY commented Jan 5, 2022

I set tabprefix to the value you provided and set placeholder output replacements to return empty value for identifier to pretend the placeholders returned empty value, which seems to be your case.

placeholder-output-replacements:
  "%premiumvanish_isvanished%":
    "%premiumvanish_isvanished%": ""
  "%reloadedutils_blinken%":
    "%reloadedutils_blinken%": ""

This is what I got:
image
I am, therefore, not able to reproduce this issue with provided steps.

@NEZNAMY NEZNAMY added the On hold: Unable to reproduce Provided steps were not enough to reproduce the issue label Jan 5, 2022
@NEZNAMY
Copy link
Owner

NEZNAMY commented Jan 31, 2022

Try with 3.0.2

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 10, 2022

Any news @supermem99 ?

@supermem99
Copy link
Author

supermem99 commented Feb 10, 2022

Any news @supermem99 ?

No its not better. The empty spaces are not there but the placeholders will be shown. Very buggy to me. But maybe its only to my users.yml. Because to players its isnt buggy

@supermem99
Copy link
Author

Screenshot_3

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 11, 2022

I have no idea why and can't fix it without steps to reproduce that actually work.

@supermem99
Copy link
Author

Can i send you my files?

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 11, 2022

I will not be able to test them because I don't have the plugins you are using placeholders from.

@supermem99
Copy link
Author

Ok. Actually its now permanent like the picture.
But only to users from users.yml

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 11, 2022

image
image

@supermem99
Copy link
Author

supermem99 commented Feb 11, 2022

Ok but its not the placeholder which have the issue. Its something i have to test maybe with other Placeholder

Placeholder from Plugin is our systempl

Wait i will test it today

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 11, 2022

Give me one that I can try myself without having to buy any plugins.

@supermem99
Copy link
Author

14.02.2022 - 03:50:44 - [TAB v3.0.2] An error occurred when refreshing placeholders
14.02.2022 - 03:50:44 - java.lang.NumberFormatException: Cannot parse null string
14.02.2022 - 03:50:44 -        at java.base/java.lang.Integer.parseInt(Integer.java:630)
14.02.2022 - 03:50:44 -        at java.base/java.lang.Integer.parseInt(Integer.java:786)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.sorting.types.Placeholder.getChars(Placeholder.java:39)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.sorting.Sorting.getTeamName(Sorting.java:109)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.nametags.NameTag.updateTeam(NameTag.java:280)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.nametags.NameTag.refresh(NameTag.java:85)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.PlaceholderManagerImpl.refresh(PlaceholderManagerImpl.java:88)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.features.PlaceholderManagerImpl.refresh(PlaceholderManagerImpl.java:68)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.CpuManager.lambda$runMeasuredTask$2(CpuManager.java:108)
14.02.2022 - 03:50:44 -        at me.neznamy.tab.shared.CpuManager.lambda$submit$5(CpuManager.java:155)
14.02.2022 - 03:50:44 -        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
14.02.2022 - 03:50:44 -        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
14.02.2022 - 03:50:44 -        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
14.02.2022 - 03:50:44 -        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
14.02.2022 - 03:50:44 -        at java.base/java.lang.Thread.run(Thread.java:833)

thats the cause i think

@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 14, 2022

Will be fixed in the next version. For now manually lowercase all outputs in placeholder sorting type in config.

@NEZNAMY NEZNAMY added this to the 3.1.0 milestone Feb 14, 2022
@NEZNAMY NEZNAMY added the Type: Bug Plugin is not working as described on the wiki label Feb 14, 2022
@NEZNAMY
Copy link
Owner

NEZNAMY commented Feb 14, 2022

Original issue will likely be fixed in the next update where the feature is reworked.

@supermem99
Copy link
Author

Will be fixed in the next version. For now manually lowercase all outputs in placeholder sorting type in config.

I did it, but its almost still there.
Screenshot_4

@NEZNAMY NEZNAMY closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold: Unable to reproduce Provided steps were not enough to reproduce the issue Type: Bug Plugin is not working as described on the wiki
Projects
None yet
Development

No branches or pull requests

2 participants