Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Ticket] Editing Comments (with cargo build bug in dev-check!!!) #434

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

nole2701
Copy link
Collaborator

Users who are logged in will now be able to edit their comments.

Changed designs in pre-existing components:

  • Added a field in comment.rs to indicate whether a comment has been edited and changed all relevant references to include it.
  • Created a comment value context that stores values for when posting/editing comments. Replaces old method of declaring state.
  • Created a comment state context to track if a comment is being edited/created. Allows the state of [isCommenting, setIsCommenting] to be shared across multiple components.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for dailp ready!

Name Link
🔨 Latest commit 49ae737
🔍 Latest deploy log https://app.netlify.com/sites/dailp/deploys/67521f5cc6d16700080ea73f
😎 Deploy Preview https://deploy-preview-434--dailp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@GracefulLemming GracefulLemming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address notes about edited in update_comment.sql and all notes about unused code.

In the meantime, ill hopefully be able to wrap up the SQLX error so we can get this merged.

@GracefulLemming GracefulLemming merged commit f891ac7 into main Dec 5, 2024
5 checks passed
@GracefulLemming GracefulLemming deleted the edit-comments branch December 5, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants