Format queries/mutations for comments to work with GraphCache #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dailp canceled.
|
CharlieMcVicker
commented
Dec 29, 2023
| query WordComments($wordId: UUID!) { | ||
| wordById(id: $wordId) { | ||
| id |
There was a problem hiding this comment.
We always need to fetch IDs if we want this to work
Comment on lines
+430
to
+447
| fragment CommentFields on Comment { | ||
| id | ||
| postedAt { | ||
| timestamp | ||
| date { | ||
| year | ||
| month | ||
| day | ||
| formattedDate | ||
| } | ||
| } | ||
| postedBy { | ||
| id | ||
| displayName | ||
| } | ||
| textContent | ||
| commentType | ||
| } |
There was a problem hiding this comment.
These common fields used by two queries and the post mutation are now in a fragment.
Comment on lines
452
to
454
| comments { | ||
| id | ||
| postedAt { | ||
| timestamp | ||
| date { | ||
| year | ||
| month | ||
| day | ||
| formattedDate | ||
| } | ||
| } | ||
| postedBy { | ||
| id | ||
| displayName | ||
| } | ||
| textContent | ||
| commentType | ||
| ...CommentFields | ||
| } |
There was a problem hiding this comment.
The fragment replaces these fields here
Comment on lines
594
to
+606
| ... on AnnotatedForm { | ||
| __typename | ||
| id | ||
| comments { | ||
| ...CommentFields | ||
| } | ||
| } | ||
| ... on DocumentParagraph { | ||
| __typename | ||
| id | ||
| comments { | ||
| ...CommentFields | ||
| } |
There was a problem hiding this comment.
We fetch the comments and the fields we need when we post, so we have an up-to-date version on the frontend as soon as the mutation finishes.
GracefulLemming
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: Comments only sometimes work
Currently, comments are posted successfully, but the UX doesn't update automatically. By changing what we fetch in the queries (there is no change to the typescript here) we will get the caching behavior we want. That is, when you post a comment, the word/paragraph comments query will be updated.
This PR should be a great example of making something work with GraphCache!