Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ansible DEFAULT_LOCAL_TMP for files stored on the ansible controller #355

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

zerwes
Copy link
Contributor

@zerwes zerwes commented Nov 11, 2024

Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, very good find! Thank you for the contribution.

I just found some tiny bits of lint. Could you please fix them and then I'll merge.

roles/elasticsearch/tasks/elasticsearch-security.yml Outdated Show resolved Hide resolved
roles/elasticsearch/tasks/elasticsearch-security.yml Outdated Show resolved Hide resolved
roles/elasticsearch/tasks/elasticsearch-security.yml Outdated Show resolved Hide resolved
zerwes and others added 3 commits November 16, 2024 07:18
Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
Co-authored-by: Thomas Widhalm <widhalmt@widhalm.or.at>
@zerwes
Copy link
Contributor Author

zerwes commented Nov 16, 2024

Oh, very good find! Thank you for the contribution.

I just found some tiny bits of lint. Could you please fix them and then I'll merge.

Thank you @widhalmt for the hint and suggestions and sorry for the error.
Now a git grep ': "{{' in the repo is silent.

@widhalmt widhalmt enabled auto-merge November 26, 2024 08:50
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait. And a big thank you for your contribution!

Approved.

@widhalmt widhalmt added this pull request to the merge queue Nov 26, 2024
Merged via the queue into NETWAYS:main with commit 6967c27 Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: role is not multi user aware due to hard coded file in /tmp
2 participants