Add exception to KICS for http in non-security scenario #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use `http` without `s` for certain scenarios. This commit will introduce an exception so KICS will not complain about it.
|
Do you want to make the same exeption for another lines with http in this PR? Is it possible to define a "global" exception rule like in lint? |
|
I guess, a global exception is possible. But I don't want to do it. Because most of the time, having this rule intact is a good thing. And I guess, we will be removing "non security" scenarios anyway sooner or later. Thanks for pointing out the other line. I'll add it as well. |
afeefghannam89
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
httpwithoutsfor certain scenarios. This commit will introduce an exception so KICS will not complain about it.