Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed filebeat config template to actually use tcp and udp port vars #310

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fixed filebeat config template to actually use tcp and udp port vars #310

merged 1 commit into from
Feb 1, 2024

Conversation

lcndsmr
Copy link
Member

@lcndsmr lcndsmr commented Feb 1, 2024

Filebeat.yml.j2 now uses the vars beats_filebeat_syslog_tcp_port and beats_filebeat_syslog_tcp_port for the udp and tcp inputs.

Fixes #309

@lcndsmr lcndsmr requested a review from a team February 1, 2024 14:29
tbauriedel
tbauriedel approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lcndsmr lcndsmr added the bug Something isn't working label Feb 1, 2024
@lcndsmr lcndsmr added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 991c804 Feb 1, 2024
6 checks passed
@lcndsmr lcndsmr deleted the fix/filebeat-vars-309 branch February 1, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbauriedel tbauriedel tbauriedel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: beats_filebeat_syslog_udp_port and beats_filebeat_syslog_tcp_port have no impact
2 participants
@lcndsmr @tbauriedel