Elasticsearch config #288
Merged
Elasticsearch config #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster nodes, are added to seed hosts
|
Hey, thanks for the contribution! We'll review it and merge if possible. Please note that checks are failing to a problem in our pipelines, that doesn't mean, your code is broken. As soon as #279 is merged, you can merge |
widhalmt
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Thanks again for the contribution. I have a few changes to request.
Some comments are just that - comments. Please just close the conversation when you read them and agree.
And I have to dig into that auto-enrollment part on my side. Maybe I find a colleague that has more experience with it.
widhalmt
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks and fixes to Elasticsearch configuration file