Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Certificate passphrase check #238

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Feature: Certificate passphrase check #238

wants to merge 52 commits into from

Conversation

danopt
Copy link
Member

@danopt danopt commented Aug 21, 2023 •
edited
Loading

#42

  • Introduces a new parameter to cert_info module named passphrase_check
  • If passphrase_check is set to true, the module will only check if current passphrase is working and returns the result of it, but will not return any information about the certificate

@danopt danopt marked this pull request as draft August 21, 2023 13:05
danopt added 15 commits August 28, 2023 13:01
@danopt danopt mentioned this pull request Aug 28, 2023
Open
@danopt danopt requested review from widhalmt, mkayontour and martialblog and removed request for widhalmt August 31, 2023 11:25
martialblog
martialblog reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@martialblog martialblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sound.

Just have some questions. Otherwise looks very good.

plugins/modules/README.md Outdated Show resolved Hide resolved
tests/unit/plugins/modules/test_cert_info.py Show resolved Hide resolved
@martialblog
Copy link
Member

👍 LGTM

martialblog
martialblog previously approved these changes Sep 25, 2023
View reviewed changes
@danopt danopt added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 25, 2023
@danopt danopt added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 25, 2023
@widhalmt widhalmt added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2023
@widhalmt widhalmt added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@widhalmt
Copy link
Member

Sorry, I totally missed this one: Please add https://github.com/NETWAYS/ansible-collection-elasticstack/blob/feature/crt_passphrase_check/.github/workflows/test_roles_pr.yml#L33 to your GitHub action. Otherwise GitHub will not start mandatory checks while in the Merge Queue.

widhalmt
widhalmt previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most steps were already approved and tested. So here's my approve for automated tests in the merge queue.

@danopt danopt enabled auto-merge September 28, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martialblog martialblog martialblog left review comments

@widhalmt widhalmt widhalmt left review comments

@mkayontour mkayontour Awaiting requested review from mkayontour

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danopt @martialblog @widhalmt