Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full stack workflow on all containers #194

Closed
afeefghannam89 opened this issue Jun 21, 2023 · 7 comments · Fixed by #279
Closed

Fix full stack workflow on all containers #194

afeefghannam89 opened this issue Jun 21, 2023 · 7 comments · Fixed by #279
Assignees
Labels
feature New feature or request
Milestone

Comments

@afeefghannam89
Copy link
Member

Full stack work flow does not work as expected on some containers. We should fix this or remove these containers from testing.

@afeefghannam89 afeefghannam89 self-assigned this Jun 21, 2023
@afeefghannam89 afeefghannam89 added the feature New feature or request label Jun 21, 2023
@afeefghannam89 afeefghannam89 added this to the 1.1.0 milestone Jun 21, 2023
@widhalmt
Copy link
Member

Do you have a list which work and which won't? I tried to focus on Ubuntu 22.04 LTS and Rocky 8 to reflect what I see most at customers.

@afeefghannam89
Copy link
Member Author

Rocky9 I have fixed and centos7 I removed from the tests. The rest was only timeout.

@lcndsmr
Copy link
Member

lcndsmr commented Jun 30, 2023

Is the issue still an issue or did you fix it? @afeefghannam89

@afeefghannam89
Copy link
Member Author

@dnssmr it is fixed but not merged yet. The fix is in this branch fix/pipelines

@widhalmt
Copy link
Member

widhalmt commented Jul 3, 2023

@afeefghannam89 you told me to ignore this branch. ;-) Should we merge it now?

@afeefghannam89
Copy link
Member Author

@widhalmt I meant another one. This branch fix/pipelines is ready to review :) I have closed the PR, which I meant to ignore.

@widhalmt
Copy link
Member

widhalmt commented Jul 5, 2023

Ok, great. :-) Sorry for the confusion.

github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2023
* Restrict the pull request workflow, fix #180 
* Use python 3.8 in Logstash pipeline, fix #189 
* Only run pr workflow while opening a pull request, but not in merge
queue #193
* Merge or squeeze logstash CI/CD pipelines #172
* Fix full stack workflow on all containers #194

---------

Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
Restarting Elasticsearch takes quite a while and may lead to connection
issues as well as sync issues. So keeping restarts to a minimum is
important. These changes will make sure that, even when the `Restart
Elasticsearch` handler is notified, it will only restart if
Elasticsearch was running before. If there's a fresh start (after
reconfiguration) we don't need to restart again.

Same goes for Logstash and Kibana. Some restarts of these tools happen
fairly fast. But others (like after fresh installs or updates) will
trigger internal jobs that should not be intercepted by another restart.

Beats restart very fast and as far as I know there's not a big downside
to restarting them right after the first start so I didn't include them
in the change.

Additionally, this PR will make sure some tasks in `verify.yml` of the
full stack are only run when the service to be checked is actually
running on this node. This helps with spreading services over nodes to
save ressources.

Since GitHub hosted runners are quite low on ressources we can't run
every service on every node in a cluster setup anymore. So this PR will
make sure that only Elasticsearch runs everywhere and the others are
spread out.

Caches get cleared after every role in during a Molecule test. This
helps with saving ressources, too.

Elasticsearch still won't sync all shards due to full volumes, the
watermarks for Elasticseach are set to extremely high volumes so that
the cluster can at least get into sync.

fixes #278
fixes #141 
fixes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants