Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce VM feature "enableComponentSrcDataKey" as a config option #38

Merged
merged 32 commits into from
Jul 15, 2024
Merged

Introduce VM feature "enableComponentSrcDataKey" as a config option #38

merged 32 commits into from
Jul 15, 2024

Conversation

bb-face
Copy link
Collaborator

@bb-face bb-face commented Jul 10, 2024 •
edited by elliotBraem
Loading

Resolves #37

bb-face and others added 26 commits June 20, 2024 10:49
@bb-face
Add hot reload
2a91549
@bb-face
Fix enableHotReload test
b76650b
@bb-face
Fix tests
30c9c1b
@bb-face
Fix tests
63cda36
@bb-face
Refactor
4eff901
@bb-face
Revert style changes
68b09a8
@bb-face
Fix socket address
d1a2839
@bb-face
Fix ws address
bcd6727 
test structure

WIP: websocket test

WIP: hot realod websocket test

Remove test
@elliotBraem
update docs
8136a21
@elliotBraem
adds tests
f098c73
@elliotBraem
adds component
0f99176
@elliotBraem
Merge branch 'main' into add-hot-reload
007f6f5
@bb-face
WIP: working test on port 3001
f0371ee
@bb-face
Fix test, not time dependend now
d2ba5fa
@bb-face
Move hotReload to config
356578e
@bb-face
Single param for hotReload
81c8561
@elliotBraem
adds config object
caa55d0
@elliotBraem
Merge branch 'main' of https://github.com/nearbuilders/near-bos-webco…
e149502 
…mponent into add-hot-reload
@elliotBraem
clean up
4eb2a27
@elliotBraem
fix readme
84a6ad1
@elliotBraem
formatting
425b02c
@elliotBraem
Merge branch 'main' of https://github.com/nearbuilders/near-bos-webco…
1790cc0 
…mponent into add-hot-reload
@elliotBraem
formatting
062c5d9
@bb-face
Failing test
f3c1c39
@bb-face
Working test
61822a3
@bb-face
Fixing tests
bc08d5c
@bb-face bb-face requested a review from elliotBraem July 10, 2024 15:14
@bb-face bb-face linked an issue Jul 10, 2024 that may be closed by this pull request
Introduce VM feature "enableComponentSrcDataKey" as a config option #37
Closed
3 tasks
bb-face and others added 3 commits July 12, 2024 14:35
@bb-face
Update readme
2573239
@bb-face
Merge branch '37-introduce-vm-feature-enablecomponentsrcdatakey-as-a-…
8471322 
…config-option' of github.com:NEARBuilders/near-bos-webcomponent into 37-introduce-vm-feature-enablecomponentsrcdatakey-as-a-config-option
@elliotBraem
Merge branch 'main' into 37-introduce-vm-feature-enablecomponentsrcda…
2bd71d4 
…takey-as-a-config-option
@elliotBraem elliotBraem marked this pull request as ready for review July 12, 2024 14:26
@elliotBraem elliotBraem changed the title 37 introduce vm feature enablecomponentsrcdatakey as a config option Introduce VM feature "enableComponentSrcDataKey" as a config option Jul 12, 2024
elliotBraem
elliotBraem approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@elliotBraem elliotBraem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Thank you!

@elliotBraem elliotBraem merged commit fd97cee into main Jul 15, 2024
1 check passed
@elliotBraem elliotBraem deleted the 37-introduce-vm-feature-enablecomponentsrcdatakey-as-a-config-option branch July 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotBraem elliotBraem elliotBraem approved these changes

@petersalomonsen petersalomonsen Awaiting requested review from petersalomonsen petersalomonsen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce VM feature "enableComponentSrcDataKey" as a config option
2 participants
@bb-face @elliotBraem