Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page #124

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Profile page #124

merged 18 commits into from
Feb 2, 2024

Conversation

itexpert120
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 2:52pm

@@ -157,6 +155,7 @@ const postToCustomFeed = ({ feed, text, labels }) => {
setPostContent("");
Storage.privateSet(draftKey, props.template || "");
setHandler("autocompleteSelected"); // this is a hack to force the iframe to update
setComposeKey(generateUID());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this? How would you remember the uuid of your draft to revisit it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is just there to trigger a rerender of the compose iframe. Usually the iframe does not rerender and causes the iframe to still contain the post content after posting. This fixes that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uuid and drafts are different. The UUID is for the iframe only just to trigger a rerender

VM.require("buildhub.near/widget/md-view") || (() => <></>);
const { Button } =
VM.require("buildhub.near/widget/components.Button") || (() => <></>);
const { MarkdownView } = VM.require("buildhub.near/widget/md-view") || {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this one is perfect, nicd

@@ -1,5 +1,6 @@
const { theme } =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can remove this coming from themeprovider/ theme?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is an object and not a wrapper, else we could have wrapped all of our app within it

@elliotBraem elliotBraem merged commit 06a5c33 into develop Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants