Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor proposal feed component #912

Merged
merged 64 commits into from
Aug 9, 2024

Conversation

Megha-Dev-19
Copy link
Collaborator

All three instances use one feed component

Megha-Dev-19 and others added 30 commits December 7, 2023 15:42
@Megha-Dev-19
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Jul 30, 2024

@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 5

Your contribution is much appreciated with a final score of 5!
You have received 50 Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen
Copy link
Collaborator

The events proposal tests fails on the filtering functionality. We have the same functionality in the main devhub feed. Do we also have these featured covered in tests? If so, then we can remove theses failing tests. The Submit proposal tests also fails, but I guess that is just because of the text in the button.

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 5

@race-of-sloths
Copy link

🌟 Score recorded!

@petersalomonsen, thank you for scoring this pull request in the Race of Sloths!

@petersalomonsen
Copy link
Collaborator

Maybe consider making the workflows run the proposal feed test ( proposal.spec.js ) on all 3 instances? ( Like adding also proposal.spec.js here for example: https://github.com/NEAR-DevHub/neardevhub-bos/blob/main/.github/workflows/continuous-integration-workflow-events.yml#L41 )

@Megha-Dev-19 Megha-Dev-19 merged commit b6dcc1a into NEAR-DevHub:main Aug 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants