-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor proposal feed component #912
Refactor proposal feed component #912
Conversation
@race-of-sloths include |
@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
The events proposal tests fails on the filtering functionality. We have the same functionality in the main devhub feed. Do we also have these featured covered in tests? If so, then we can remove theses failing tests. The Submit proposal tests also fails, but I guess that is just because of the text in the button. |
@race-of-sloths score 5 |
🌟 Score recorded!@petersalomonsen, thank you for scoring this pull request in the Race of Sloths! |
Maybe consider making the workflows run the proposal feed test ( proposal.spec.js ) on all 3 instances? ( Like adding also proposal.spec.js here for example: https://github.com/NEAR-DevHub/neardevhub-bos/blob/main/.github/workflows/continuous-integration-workflow-events.yml#L41 ) |
bc8962c
to
2763500
Compare
All three instances use one feed component