Fix report approval by admins and when automatic #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvoosten
force-pushed
the
AB-1185-only-warn-about-primary-attendees-in-reports
branch
from
d1eb3eb to
088dca9
Compare
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
32d735c to
5add24a
Compare
gjvoosten
force-pushed
the
AB-1185-only-warn-about-primary-attendees-in-reports
branch
from
088dca9 to
81cce94
Compare
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
5add24a to
4f19ffb
Compare
gjvoosten
force-pushed
the
AB-1185-only-warn-about-primary-attendees-in-reports
branch
from
81cce94 to
f1a885c
Compare
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
4f19ffb to
a9d3109
Compare
gjvoosten
force-pushed
the
AB-1185-only-warn-about-primary-attendees-in-reports
branch
from
f1a885c to
628c6ca
Compare
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
a9d3109 to
5c0dcd2
Compare
gjvoosten
force-pushed
the
AB-1185-only-warn-about-primary-attendees-in-reports
branch
from
628c6ca to
950f948
Compare
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
5c0dcd2 to
a9fa815
Compare
Base automatically changed from
AB-1185-only-warn-about-primary-attendees-in-reports
to
main
October 4, 2024 13:50
…tically published
The front-end already allowed it, but the back-end refused it.
gjvoosten
force-pushed
the
AB-1186-allow-admins-to-approve-all-reports
branch
from
a9fa815 to
59a9358
Compare
midmarch
requested changes
Oct 7, 2024
There was a problem hiding this comment.
The front-ends suggest, to an ANET admin, that a draft report can be approved. When this approval button is pressed, the servver returns with an error:
Bad Request: Exception while fetching data (/approveReport) : This report is not pending approval
The "Approve" button should not be enabled on a draft report.
This includes admins; fixes commit e0cdf7d
Caused by a change for AB#991 quite some time ago; fixed in an additional commit on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow admins to approve all reports. The front-end already allowed it, but the back-end refused it.
Automatic report approval (after the timeout set in the dictionary) did not work for reports that had only been submitted; this is now fixed.
Show "system" instead of "Unspecified" when a report was automatically published.
Closes AB#1186
User changes
Superuser changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules