Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when changing dates in the position history #4932

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix error when changing dates in the position history #4932

merged 3 commits into from
Sep 26, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Sep 23, 2024 •
edited
Loading

Closes AB#722

User changes

  • None.

Superuser changes

  • Changing start or end dates when manually editing position history works correctly again.

Admin changes

  • None.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten added the debt label Sep 23, 2024
@gjvoosten gjvoosten force-pushed the AB-722-fix-editing-position-history branch from 2fc6825 to 72b0c01 Compare September 24, 2024 09:17
@gjvoosten gjvoosten marked this pull request as ready for review September 24, 2024 09:34
@gjvoosten gjvoosten force-pushed the AB-722-fix-editing-position-history branch from 72b0c01 to 128d9ee Compare September 25, 2024 09:28
midmarch
midmarch approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely, both editing history on the position, as well editing the career of a person.

image

@gjvoosten gjvoosten merged commit ff5c994 into main Sep 26, 2024
20 checks passed
@gjvoosten gjvoosten deleted the AB-722-fix-editing-position-history branch September 26, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midmarch midmarch midmarch approved these changes

@pacodelcastillolopez pacodelcastillolopez Awaiting requested review from pacodelcastillolopez

Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjvoosten @midmarch