Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit APP6 Symbol Set from parent organization #4924

Merged

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Sep 18, 2024

In addition to the Context and Standard Identity, also inherit the Symbol Set from the parent organization.

Closes AB#1184

User changes

  • When not explicitly set for an organization, the APP6 Symbol Set is inherited from the parent organization.

Superuser changes

  • Superusers can leave the APP6 Symbol Set for an organization empty, in which case it will be inherited from the parent organization.

Admin changes

  • None.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review September 18, 2024 10:30
@gjvoosten gjvoosten force-pushed the AB-1184-inherit-app6-symbolset-from-parent-organization branch 3 times, most recently from 01216e8 to dbd960e Compare September 26, 2024 06:33
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nice, in this test I defined NATO as being an APP6 ground unit, and the NATO Agencies an APP6 civilian organization.

image

But I had to reset all (maybe most) existing organizarions, the app6symbolSet column.

@gjvoosten gjvoosten force-pushed the AB-1184-inherit-app6-symbolset-from-parent-organization branch from dbd960e to 80f5e1d Compare October 1, 2024 13:40
@gjvoosten
Copy link
Collaborator Author

But I had to reset all (maybe most) existing organizarions, the app6symbolSet column.

Updated the migration.

@gjvoosten gjvoosten requested a review from midmarch October 1, 2024 13:42
In addition to the Context and Standard Identity, also inherit the
Symbol Set from the parent organization.
Only migrate/set app6symbolSet for sub-level organizations.
@gjvoosten gjvoosten force-pushed the AB-1184-inherit-app6-symbolset-from-parent-organization branch from 80f5e1d to 8b5db67 Compare October 1, 2024 14:56
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this PR

@gjvoosten gjvoosten merged commit 2afa3dd into main Oct 1, 2024
20 checks passed
@gjvoosten gjvoosten deleted the AB-1184-inherit-app6-symbolset-from-parent-organization branch October 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants