Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct classification in report print view footer #4825

Merged

Conversation

Chessray
Copy link
Contributor

@Chessray Chessray commented Jun 14, 2024

The classification banner in the report print view's footer will now display the classification correctly instead of the default defined in the dictionary.

Closes AB#1114
(relates to AB#1053)

User changes

  • User will now see the correct classification displayed

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@Chessray Chessray marked this pull request as ready for review June 14, 2024 15:55
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests that e.g.:

  • a report without classification shows the dictionary default in both the compact header and the footer
  • a report with classification shows the report's classification in both the compact header and the footer

@gjvoosten gjvoosten changed the title AB#1114: Display correct classification in report print preview footer Display correct classification in report print preview footer Jun 17, 2024
@gjvoosten gjvoosten changed the title Display correct classification in report print preview footer Display correct classification in report print view footer Jun 17, 2024
@Chessray Chessray force-pushed the AB-1114-report-footer-classification-banner-shows-only-demo branch 4 times, most recently from b8bbfff to f34ecf9 Compare June 17, 2024 12:46
@Chessray Chessray requested a review from gjvoosten June 17, 2024 13:57
@Chessray Chessray force-pushed the AB-1114-report-footer-classification-banner-shows-only-demo branch from f34ecf9 to 961c6c0 Compare June 18, 2024 07:18
@Chessray Chessray requested a review from gjvoosten June 18, 2024 07:18
@Chessray Chessray force-pushed the AB-1114-report-footer-classification-banner-shows-only-demo branch from 961c6c0 to e54729b Compare June 18, 2024 07:24
@gjvoosten gjvoosten merged commit cd50726 into main Jun 18, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB-1114-report-footer-classification-banner-shows-only-demo branch June 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants