Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap the engagement information and details #4755

Merged
merged 1 commit into from
May 16, 2024
Merged

Swap the engagement information and details #4755

merged 1 commit into from
May 16, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Apr 30, 2024 •
edited
Loading

In the report form, swap the engagement information and details sections.
This makes it more in line with the report show page.

Closes AB#1092

User changes

  • The Engagement details input section now comes before the Engagement information input section in the report form.

Superuser changes

  • None.

Admin changes

  • None.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review April 30, 2024 08:19
@gjvoosten gjvoosten requested review from Chessray and midmarch April 30, 2024 08:19
@gjvoosten gjvoosten force-pushed the AB-1092-swap-engagement-information-and-details-in-form branch 4 times, most recently from 2faf4d1 to 1bbbd71 Compare May 7, 2024 12:00
@gjvoosten gjvoosten force-pushed the AB-1092-swap-engagement-information-and-details-in-form branch 2 times, most recently from dad619d to 26df4b3 Compare May 13, 2024 09:06
@gjvoosten
AB#1092 In the report form, swap the engagement information and detai…
98fcc42 
…ls sections

This makes it more in line with the report show page.
@gjvoosten gjvoosten force-pushed the AB-1092-swap-engagement-information-and-details-in-form branch from 26df4b3 to 98fcc42 Compare May 15, 2024 13:21
midmarch
midmarch approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjvoosten gjvoosten merged commit 6bcfb02 into main May 16, 2024
19 checks passed
@gjvoosten gjvoosten deleted the AB-1092-swap-engagement-information-and-details-in-form branch May 16, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midmarch midmarch midmarch approved these changes

@Chessray Chessray Awaiting requested review from Chessray

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjvoosten @midmarch