-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move countries to locations table #4744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
from
April 23, 2024 14:23
aa45e3a
to
2b8f0f1
Compare
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
2 times, most recently
from
April 24, 2024 07:36
f08d3c5
to
61ff9ef
Compare
1 task
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
2 times, most recently
from
April 30, 2024 14:02
c6aa67e
to
98dbe29
Compare
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
3 times, most recently
from
May 7, 2024 12:00
61a3e84
to
eb5f963
Compare
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
2 times, most recently
from
May 13, 2024 09:06
b7b2a88
to
539e2cb
Compare
- Add a new location type for countries and insert countries from STANAG 1059 in the locations table; set a few old ones to 'inactive'. - Replace people.country with a foreign key reference to locations.uuid. - Migrate existing countries, using exact matches and some heuristics; keeping the old country names if we don't have an exact match, to give users the opportunity to correct this themselves.
gjvoosten
force-pushed
the
AB-1083-move-countries-to-locations
branch
from
May 15, 2024 13:18
539e2cb
to
488ac45
Compare
midmarch
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Also change the labels for the digram/trigram fields.
midmarch
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AB#1083
User changes
Superuser changes
Admin changes
System admin changes
Add:
fields.person.regular.countries
.Checklist
repo#issue: Title
title format and these 7 rules