Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve advisors-interlocutors calendar option #4734

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

pacodelcastillolopez
Copy link
Collaborator

@pacodelcastillolopez pacodelcastillolopez commented Apr 11, 2024

In the report calendar, the organization name is now shown first, before the person's name, and when switching between interlocutors and advisors the organization name is now also switched.

Closes AB#1080

User changes

  • They will see the organization first and the people after in the engagements displayed in the calendar.
  • When they switch between advisor and interlocutor the corresponding organization is displayed in the calendar.

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten changed the title Improve advisor-interlocutors calendar option Improve advisors-interlocutors calendar option Apr 11, 2024
@Chessray
Copy link
Contributor

Would a Webdriver test make sense here?

@pacodelcastillolopez
Copy link
Collaborator Author

It would be the whole calendar is not covered with test. When I implemented the previous calendar ticket I discussed this with Gertjan and it seems back then the feature was considered to complex to cover.

client/src/components/aggregations/utils.js Outdated Show resolved Hide resolved
client/src/components/aggregations/utils.js Outdated Show resolved Hide resolved
@pacodelcastillolopez pacodelcastillolopez force-pushed the AB1080-improvements-advisor-interlocutors-calendar branch from 2a4d943 to f362ee6 Compare April 16, 2024 12:49
@gjvoosten gjvoosten merged commit 5674031 into main Apr 17, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB1080-improvements-advisor-interlocutors-calendar branch April 17, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants