Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce react-resize-detector #4717

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Mar 28, 2024

Replace unmaintained react-container-dimensions.
Replace unmaintained react-use-dimensions.

Closes AB#803

User changes

  • None

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review March 28, 2024 11:44
@gjvoosten gjvoosten force-pushed the AB-803-use-react-resize-detector branch from f901bd4 to 24f0125 Compare March 28, 2024 15:56
Replace unmaintained react-container-dimensions.
Replace unmaintained react-use-dimensions.
@gjvoosten gjvoosten force-pushed the AB-803-use-react-resize-detector branch from 24f0125 to da97e63 Compare March 28, 2024 16:00
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjvoosten gjvoosten merged commit 85f7b29 into main Apr 2, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB-803-use-react-resize-detector branch April 2, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants