Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow admins to pick the default approval organization #4657

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Allow admins to pick the default approval organization #4657

merged 1 commit into from
Feb 21, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Feb 19, 2024 •
edited
Loading

Use an advanced select, so admins don't have to copy-paste the uuid by hand.

Closes AB#1051

User changes

  • None

Superuser changes

  • None.

Admin changes

  • Admins can now pick the default approval organization with an advanced select, so they don't have to copy-paste the uuid by hand.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review February 20, 2024 07:48
@gjvoosten gjvoosten force-pushed the AB-1051-allow-admins-to-pick-defaultApprovalOrg branch 3 times, most recently from 9557440 to 88f8ff3 Compare February 20, 2024 14:21
@gjvoosten
AB#1051 Allow admins to pick the default approval organization
4ae3338 
Use an advanced select, so admins don't have to copy-paste the uuid by hand.
@gjvoosten gjvoosten force-pushed the AB-1051-allow-admins-to-pick-defaultApprovalOrg branch from 88f8ff3 to 4ae3338 Compare February 21, 2024 10:08
midmarch
midmarch approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjvoosten gjvoosten merged commit 27e0df6 into main Feb 21, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB-1051-allow-admins-to-pick-defaultApprovalOrg branch February 21, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midmarch midmarch midmarch approved these changes

@pacodelcastillolopez pacodelcastillolopez Awaiting requested review from pacodelcastillolopez

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjvoosten @midmarch