Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make end-of-tour date inclusive #4653

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

pacodelcastillolopez
Copy link
Collaborator

@pacodelcastillolopez pacodelcastillolopez commented Feb 13, 2024

The current de-activation of accounts based on end of tour date kicks before the end of the last day at work. This happens because the custom date picker used in the "Person" form rounds down the date to the start of the day. The new implementation will round up this date to the end of the day instead, so users are able to use ANET on their last day at the job.

Closes AB#1038

User changes

  • As described above.

Superuser changes

  • None.

Admin changes

  • None.

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten removed their assignment Feb 13, 2024
@gjvoosten gjvoosten marked this pull request as draft February 20, 2024 08:48
@pacodelcastillolopez pacodelcastillolopez force-pushed the AB-1038-make-end-of-tour-date-inclusive branch 4 times, most recently from 8c7a3c3 to d0d274b Compare February 20, 2024 10:49
@pacodelcastillolopez pacodelcastillolopez marked this pull request as ready for review February 20, 2024 11:12
client/src/pages/people/Form.js Outdated Show resolved Hide resolved
@pacodelcastillolopez pacodelcastillolopez force-pushed the AB-1038-make-end-of-tour-date-inclusive branch from d0d274b to cf927c7 Compare February 20, 2024 13:37
@gjvoosten gjvoosten added improvement and removed bug labels Feb 20, 2024
@gjvoosten gjvoosten merged commit 530d877 into main Feb 20, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB-1038-make-end-of-tour-date-inclusive branch February 20, 2024 14:01
@gjvoosten gjvoosten added bug and removed improvement labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants