Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing initialization of position role to init command #4501

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add missing initialization of position role to init command #4501

merged 1 commit into from
Oct 5, 2023

Conversation

midmarch
Copy link
Contributor

@midmarch midmarch commented Sep 22, 2023 •
edited by gjvoosten
Loading

This fixes the anet init method.

Resolves AB#967

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@midmarch midmarch added the bug label Sep 22, 2023
@midmarch midmarch self-assigned this Sep 22, 2023
@midmarch
Copy link
Contributor Author

midmarch commented Sep 22, 2023 •
edited
Loading

I have made RPM 83ec8b0, tested that with the Ansible script, and the "Seed the ANET database" in anet-install playbook now works.

@gjvoosten gjvoosten force-pushed the AB-967-fix-anet-init branch from 83ec8b0 to 4057ad5 Compare October 3, 2023 07:31
@gjvoosten gjvoosten changed the title Default initialization of attribute Person.role and Position.type Add missing initialization of position role to init command Oct 3, 2023
@gjvoosten gjvoosten force-pushed the AB-967-fix-anet-init branch from 4057ad5 to aa43728 Compare October 4, 2023 15:01
@gjvoosten gjvoosten merged commit 26dc10a into main Oct 5, 2023
@gjvoosten gjvoosten deleted the AB-967-fix-anet-init branch October 5, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

Assignees

@midmarch midmarch

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midmarch @gjvoosten @hyesilAnka