Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make end of tour date optional #4476

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Make end of tour date optional #4476

merged 4 commits into from
Sep 13, 2023

Conversation

og-simsoft
Copy link

@og-simsoft og-simsoft commented Sep 7, 2023 •
edited by gjvoosten
Loading

The end of tour date is now optional.

Closes AB#949

User changes

  • Users can now leave end of tour date empty.

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@og-simsoft og-simsoft self-assigned this Sep 7, 2023
@gjvoosten gjvoosten changed the title Prevent end of tour date to be mandatory Make end of tour date optional Sep 11, 2023
gjvoosten
gjvoosten requested changes Sep 11, 2023
View reviewed changes
client/src/components/CustomDateInput.js Outdated Show resolved Hide resolved
client/src/components/CustomDateInput.js Outdated Show resolved Hide resolved
client/tests/webdriver/baseSpecs/createNewPerson.spec.js Show resolved Hide resolved
client/tests/webdriver/baseSpecs/createNewPerson.spec.js Outdated Show resolved Hide resolved
@gjvoosten gjvoosten merged commit 6942884 into main Sep 13, 2023
@gjvoosten gjvoosten deleted the AB-949-Prevent-endOfTourDate-to-be-mandatory branch September 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@midmarch midmarch Awaiting requested review from midmarch

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

@mesut-simsoft mesut-simsoft Awaiting requested review from mesut-simsoft

Assignees

@og-simsoft og-simsoft

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@og-simsoft @gjvoosten