Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error handling of duplicate position code #4310

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Mar 23, 2023

Show a proper error message when someone tries to create a position with a duplicate code.

Closes AB#813

User changes

  • none

Superuser changes

  • When a superuser tries to create a position with a code that already exists, a proper error message is shown.

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten merged commit 7935dc2 into main Mar 27, 2023
@gjvoosten gjvoosten deleted the AB-813-fix-duplicate-position-code-error-handling branch March 27, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants