Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace arrow from Glyphicons Halflings with regular Unicode arrow #4299

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Replace arrow from Glyphicons Halflings with regular Unicode arrow #4299

merged 1 commit into from
Mar 17, 2023

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Mar 16, 2023 •
edited by azure-boards bot
Loading

In the report workflow, replace the arrow we used from Glyphicons Halflings, which is no longer included in Bootstrap 5, with a regular Unicode arrow.

Closes AB#633

User changes

  • Report workflow no longer contains an undefined symbol between the workflow steps, but instead shows an arrow.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten added the bug label Mar 16, 2023
midmarch
midmarch approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@midmarch midmarch merged commit 8380fe7 into main Mar 17, 2023
@midmarch midmarch deleted the AB-633-replace-halflings branch March 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midmarch midmarch midmarch approved these changes

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

@mk-simsoft mk-simsoft Awaiting requested review from mk-simsoft

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjvoosten @midmarch