Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Superusers" from organization detail page #4281

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Remove "Superusers" from organization detail page #4281

merged 2 commits into from
Mar 20, 2023

Conversation

midmarch
Copy link
Contributor

@midmarch midmarch commented Mar 8, 2023 •
edited by gjvoosten
Loading

Changes:

  • Rename label "Administrating positions" to "Assigned Superusers"
  • Remove Superuser listing of organisation positions

Closes AB#793

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@midmarch midmarch marked this pull request as draft March 8, 2023 13:59
@gjvoosten gjvoosten changed the title Drop obsolete field organization "Super Users" Change field label to "Assigned Super Users" Mar 8, 2023
@midmarch midmarch changed the title Change field label to "Assigned Super Users" Remove "Super users" from organization detail page Mar 8, 2023
@midmarch midmarch added the bug label Mar 8, 2023
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch 3 times, most recently from 483e860 to c8b3807 Compare March 8, 2023 15:57
midmarch added a commit that referenced this pull request Mar 9, 2023
@midmarch
Remove Super-user listing of organisation positions
1328459 
Super-user have no longer super-user rights on their own organisation, be default.

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from c8b3807 to 1328459 Compare March 9, 2023 10:39
@midmarch midmarch marked this pull request as ready for review March 9, 2023 13:26
@midmarch midmarch requested a review from gjvoosten March 9, 2023 13:29
midmarch added a commit that referenced this pull request Mar 10, 2023
@midmarch
Remove Super-user listing of organisation positions
e85a197 
Super-user have no longer super-user rights on their own organisation, be default.

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch 3 times, most recently from 51d8cd7 to e515e9d Compare March 15, 2023 13:31
@midmarch midmarch requested a review from gjvoosten March 15, 2023 13:57
midmarch added a commit that referenced this pull request Mar 15, 2023
@midmarch
Remove "Super users" from organization detail / preview page
66edb39 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from e515e9d to 66edb39 Compare March 15, 2023 14:12
gjvoosten
gjvoosten requested changes Mar 16, 2023
View reviewed changes
anet-dictionary.yml Outdated Show resolved Hide resolved
anet-dictionary.yml Outdated Show resolved Hide resolved
client/tests/e2e/permissions.js Outdated Show resolved Hide resolved
client/src/pages/organizations/Laydown.js Outdated Show resolved Hide resolved
client/tests/e2e/permissions.js Outdated Show resolved Hide resolved
client/tests/e2e/permissions.js Outdated Show resolved Hide resolved
client/tests/e2e/permissions.js Outdated Show resolved Hide resolved
insertBaseData-psql.sql Outdated Show resolved Hide resolved
midmarch added a commit that referenced this pull request Mar 20, 2023
@midmarch
Remove "Super users" from organization detail / preview page
311aa6e 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from 66edb39 to 311aa6e Compare March 20, 2023 09:44
midmarch added a commit that referenced this pull request Mar 20, 2023
@midmarch
Remove "Super users" from organization detail / preview page
70e1154 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from 311aa6e to 70e1154 Compare March 20, 2023 09:56
midmarch added a commit that referenced this pull request Mar 20, 2023
@midmarch
Remove "Super users" from organization detail / preview page
78b409d 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from 70e1154 to 78b409d Compare March 20, 2023 10:00
midmarch added a commit that referenced this pull request Mar 20, 2023
@midmarch
Remove "Super users" from organization detail / preview page
c411a6b 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from 78b409d to c411a6b Compare March 20, 2023 10:31
midmarch added a commit that referenced this pull request Mar 20, 2023
@midmarch
Remove "Super users" from organization detail / preview page
11d13b1 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@midmarch midmarch force-pushed the AB-793-drop-old-super-user-field branch from c411a6b to 11d13b1 Compare March 20, 2023 10:39
gjvoosten pushed a commit that referenced this pull request Mar 20, 2023
@midmarch @gjvoosten
Remove "Super users" from organization detail / preview page
8727317 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests

Resolves #4281
@gjvoosten gjvoosten force-pushed the AB-793-drop-old-super-user-field branch 3 times, most recently from 3673f7e to 82a783b Compare March 20, 2023 10:49
gjvoosten
gjvoosten requested changes Mar 20, 2023
View reviewed changes
client/tests/e2e/permissions.js Outdated Show resolved Hide resolved
@gjvoosten gjvoosten changed the title Remove "Super users" from organization detail page Remove "Superusers" from organization detail page Mar 20, 2023
midmarch and others added 2 commits March 20, 2023 14:44
@midmarch @gjvoosten
AB#793 Remove "Super users" from organization detail / preview page
2709977 
Changes:
- Dictionary: Rename label "Administrating positions" to "Assigned Super Users"
- Remove Super-user listing of organisation positions.
- DB-test-data: Andrew ('EF 1 Manager') is a super-user of 'EF 1' organisation.
- e2e-tests: Adapt (fix) tests
@gjvoosten
AB#793 Consistently spell "superuser" as one word
6de11c9
@gjvoosten gjvoosten force-pushed the AB-793-drop-old-super-user-field branch from 82a783b to 6de11c9 Compare March 20, 2023 13:47
@gjvoosten gjvoosten merged commit 01d2d8a into main Mar 20, 2023
@gjvoosten gjvoosten deleted the AB-793-drop-old-super-user-field branch March 20, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midmarch @gjvoosten