Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breadcrumb trail for tasks #4278

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Add breadcrumb trail for tasks #4278

merged 4 commits into from
Mar 17, 2023

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Mar 8, 2023 •
edited
Loading

Tasks are now shown using a breadcrumb trail, showing a task all the way to its top-level parent.

Closes AB#758, AB#776

User changes

  • Tasks are now shown with their context: a breadcrumb trail up to the top-level parent task.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch 4 times, most recently from 07c513d to bfac420 Compare March 9, 2023 15:35
@gjvoosten gjvoosten marked this pull request as ready for review March 9, 2023 15:42
hyesilAnka
hyesilAnka previously requested changes Mar 12, 2023
View reviewed changes
client/src/components/ReportSummary.js Outdated Show resolved Hide resolved
client/src/components/BreadcrumbTrail.js Outdated Show resolved Hide resolved
client/src/components/BreadcrumbTrail.js Outdated Show resolved Hide resolved
client/src/pages/reports/Compact.js Outdated Show resolved Hide resolved
@gjvoosten gjvoosten force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch from bfac420 to d4865c1 Compare March 15, 2023 08:47
@gjvoosten gjvoosten requested a review from hyesilAnka March 15, 2023 08:48
@gjvoosten gjvoosten force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch from d4865c1 to 925fc3a Compare March 15, 2023 15:04
@midmarch midmarch force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch from 925fc3a to f2a2d9b Compare March 16, 2023 11:20
@gjvoosten gjvoosten force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch 2 times, most recently from 40e27a2 to 61d29dc Compare March 16, 2023 16:10
@midmarch midmarch force-pushed the AB-758-add-breadcrumb-trail-for-tasks branch from 61d29dc to 79c6518 Compare March 17, 2023 13:28
midmarch
midmarch reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching tasks:

image

Sorting the tasks on parent, alphabetically would be nice, across total result set, would be nice.

midmarch
midmarch reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breadcumbs in recent efforts.

image

Not in the scope of this specific issue, but there is room for improvement to select a task in the hiearchy by using the hierarchy.

image

@midmarch midmarch merged commit d0a9f63 into main Mar 17, 2023
@midmarch midmarch deleted the AB-758-add-breadcrumb-trail-for-tasks branch March 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyesilAnka hyesilAnka hyesilAnka approved these changes

@midmarch midmarch midmarch approved these changes

@mk-simsoft mk-simsoft Awaiting requested review from mk-simsoft

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjvoosten @midmarch @hyesilAnka