Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide parent task if no parent task, and show sub tasks #4271

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Hide parent task if no parent task, and show sub tasks #4271

merged 3 commits into from
Mar 20, 2023

Conversation

mk-simsoft
Copy link
Contributor

@mk-simsoft mk-simsoft commented Mar 3, 2023 •
edited by gjvoosten
Loading

Only show parent task for tasks with a parent, and show sub tasks if a task has any.

Closes AB#777, AB#778

User changes

  • Parent task is only shown if a task has one.
  • A task's sub tasks are now also shown if there are any.
  • Parent task is only shown if a task has one in task hover preview.
  • A task's sub tasks are now also shown if there are any in task preview with hover.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 7ee62b9 to 9d95a21 Compare March 3, 2023 06:51
@mk-simsoft mk-simsoft requested a review from midmarch March 3, 2023 06:57
gjvoosten
gjvoosten requested changes Mar 6, 2023
View reviewed changes
anet-dictionary.yml Outdated Show resolved Hide resolved
src/main/resources/anet-schema.yml Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
@gjvoosten gjvoosten changed the title AB#778: Hide parent Task Field if No Parent Task Hide parent Task Field if No Parent Task Mar 6, 2023
@gjvoosten gjvoosten changed the title Hide parent Task Field if No Parent Task Hide parent task if no parent task, and show sub tasks Mar 6, 2023
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 9d95a21 to 25525d8 Compare March 6, 2023 11:00
@mk-simsoft mk-simsoft requested a review from gjvoosten March 6, 2023 11:05
gjvoosten
gjvoosten requested changes Mar 6, 2023
View reviewed changes
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
anet-dictionary.yml Outdated Show resolved Hide resolved
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 25525d8 to b2fb83a Compare March 6, 2023 12:14
@mk-simsoft mk-simsoft requested a review from gjvoosten March 6, 2023 12:15
gjvoosten
gjvoosten requested changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some wdio tests as well.

client/src/pages/tasks/Show.js Show resolved Hide resolved
@mk-simsoft mk-simsoft requested a review from gjvoosten March 9, 2023 08:57
gjvoosten
gjvoosten requested changes Mar 9, 2023
View reviewed changes
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/pages/tasks/Show.js Outdated Show resolved Hide resolved
client/src/components/previews/TaskPreview.js Outdated Show resolved Hide resolved
@mk-simsoft mk-simsoft requested a review from gjvoosten March 10, 2023 06:23
@midmarch
Copy link
Contributor

Can we rename childrenTasks to childTasks ?

@gjvoosten gjvoosten force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 29f4581 to 2d0b02c Compare March 15, 2023 09:13
gjvoosten
gjvoosten requested changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some client-side tests that assert:

  • that the parent task is shown for sub-level tasks
  • that the parent task is not shown for top-level tasks
  • that sub-level tasks are shown for a task that has some
  • that sub-level tasks are not shown for a task that none

@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch 4 times, most recently from 8e01518 to f8e5630 Compare March 17, 2023 14:03
@mk-simsoft mk-simsoft requested a review from gjvoosten March 20, 2023 05:58
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from f8e5630 to 0d580ad Compare March 20, 2023 06:48
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 0d580ad to 533978b Compare March 20, 2023 09:51
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 533978b to a64f0df Compare March 20, 2023 11:20
@mk-simsoft mk-simsoft requested a review from gjvoosten March 20, 2023 11:20
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from a64f0df to 234eb67 Compare March 20, 2023 11:35
@mk-simsoft
AB#777: Add Sub-Tasks field to efforts
4557325 
AB#777, AB#778: Change TaskPreview component parent and sub tasks behaviour
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 234eb67 to 0ed4c67 Compare March 20, 2023 11:44
@mk-simsoft mk-simsoft force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from 0ed4c67 to a069077 Compare March 20, 2023 12:30
@mk-simsoft mk-simsoft requested a review from gjvoosten March 20, 2023 12:52
@gjvoosten gjvoosten force-pushed the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch from a069077 to 3de1e19 Compare March 20, 2023 13:42
@gjvoosten gjvoosten merged commit c756421 into main Mar 20, 2023
@gjvoosten gjvoosten deleted the AB-778--hide-parent-task-field-if-no-parent-task-in-the-preview-field branch March 20, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@ce-simsoft ce-simsoft Awaiting requested review from ce-simsoft

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

@midmarch midmarch Awaiting requested review from midmarch

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mk-simsoft @midmarch @gjvoosten