Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing entities to report summary #4215

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Add missing entities to report summary #4215

merged 3 commits into from
Jan 23, 2023

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Jan 17, 2023 •
edited by gjvoosten
Loading

In the report summary view, all entities (attendees and tasks) are displayed when assessments are activated in the optional fields.

Closes AB#670

User changes

  • Report summary view displays the tasks and attendees correctly

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@anilsonmez-simsoft anilsonmez-simsoft self-assigned this Jan 17, 2023
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-670-missing-entities-in-report-summary branch from 39bc993 to d2e1ad8 Compare January 17, 2023 07:44
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-670-missing-entities-in-report-summary branch from d2e1ad8 to 1b48bff Compare January 17, 2023 08:09
@gjvoosten gjvoosten changed the title Missing entities in report summary Add missing entities to report summary Jan 18, 2023
gjvoosten
gjvoosten requested changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions.

@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-670-missing-entities-in-report-summary branch from ff07393 to 534f87d Compare January 18, 2023 13:51
@gjvoosten gjvoosten force-pushed the AB-670-missing-entities-in-report-summary branch from 534f87d to 6ac0cd8 Compare January 19, 2023 14:36
anilsonmez-simsoft and others added 3 commits January 19, 2023 16:55
@anilsonmez-simsoft @gjvoosten
AB#670: Show attendees without assessments in report summary
85b3230
@anilsonmez-simsoft @gjvoosten
AB#670: Add client side tests for report summary view attendees
5b3ee10
@gjvoosten
AB#670: Properly sort attendees
77ee876 
Factor out common code.
When entities without assessments should be shown, properly sort them, meaning:
- attendees without assessments first, in the original sort order (e.g. by name)
- attendees with assessments last, in the original sort order (e.g. by name)
@gjvoosten gjvoosten force-pushed the AB-670-missing-entities-in-report-summary branch from 6ac0cd8 to 77ee876 Compare January 19, 2023 15:55
@gjvoosten gjvoosten merged commit c59e91f into main Jan 23, 2023
@gjvoosten gjvoosten deleted the AB-670-missing-entities-in-report-summary branch January 23, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@midmarch midmarch Awaiting requested review from midmarch

@hyesilAnka hyesilAnka Awaiting requested review from hyesilAnka

Assignees

@gjvoosten gjvoosten

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilsonmez-simsoft @gjvoosten