Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rich text headings smaller #4127

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Make rich text headings smaller #4127

merged 1 commit into from
Nov 9, 2022

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Nov 3, 2022 •
edited by azure-boards bot
Loading

Headings created in the rich text editor have smaller font sizes.

Closes AB#608

User changes

  • Headings created in the rich text editor have smaller font sizes.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AZ-608-make-rich-text-headings-smaller branch from 2c978b3 to 6686fe4 Compare November 4, 2022 06:49
@anilsonmez-simsoft anilsonmez-simsoft self-assigned this Nov 4, 2022
midmarch
midmarch requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the space between heading the following paragraph, to better show the heading belongs to the parahraph (section)

client/src/components/editor/RichTextEditor.css Outdated Show resolved Hide resolved
client/src/index.css Outdated Show resolved Hide resolved
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AZ-608-make-rich-text-headings-smaller branch 2 times, most recently from 03b5bd5 to 96c19d4 Compare November 8, 2022 11:00
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AZ-608-make-rich-text-headings-smaller branch from 96c19d4 to 6d8ddf0 Compare November 8, 2022 14:19
@midmarch midmarch self-requested a review November 9, 2022 08:20
@midmarch midmarch merged commit 0f56d6b into main Nov 9, 2022
@midmarch midmarch deleted the AZ-608-make-rich-text-headings-smaller branch November 9, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midmarch midmarch midmarch approved these changes

@gjvoosten gjvoosten Awaiting requested review from gjvoosten

Assignees

@anilsonmez-simsoft anilsonmez-simsoft

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anilsonmez-simsoft @gjvoosten @midmarch