Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix related object notes bug #4120

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Oct 19, 2022

Filtered notes are created from the state variable. Unnecessary update logic is removed as filtered notes can only be changed using the note modal.

Closes AB#602

User changes

  • Users can see the newly created object related notes without refreshing the page.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

Filtered notes are created from the state variable. Unnecessary update logic is removed as filtered notes can only be changed using the note modal.
@gjvoosten gjvoosten merged commit dc007b7 into main Oct 20, 2022
@gjvoosten gjvoosten deleted the AB-602-fix-related-object-notes-bug branch October 20, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants