Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bar chart to rollup page #4004

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Add bar chart to rollup page #4004

merged 3 commits into from
Aug 25, 2022

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Mar 31, 2022 •
edited by gjvoosten
Loading

Bar chart is added to the rollup page

Closes AB#387, #1733

User changes

  • Users can see the number of reports published and canceled during the specified period.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@anilsonmez-simsoft anilsonmez-simsoft marked this pull request as draft March 31, 2022 08:02
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-387-add-bar-chart-to-rollup branch from 8a23aaf to 8891143 Compare August 1, 2022 14:04
@anilsonmez-simsoft anilsonmez-simsoft self-assigned this Aug 18, 2022
@anilsonmez-simsoft anilsonmez-simsoft marked this pull request as ready for review August 18, 2022 09:25
gjvoosten
gjvoosten requested changes Aug 25, 2022
View reviewed changes
client/src/pages/rollup/Show.js Outdated Show resolved Hide resolved
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-387-add-bar-chart-to-rollup branch from 7c3484b to 3a569af Compare August 25, 2022 09:17
gjvoosten
gjvoosten requested changes Aug 25, 2022
View reviewed changes
client/src/pages/rollup/Show.js Outdated Show resolved Hide resolved
client/src/pages/rollup/Show.js Outdated Show resolved Hide resolved
client/src/pages/rollup/Show.js Outdated Show resolved Hide resolved
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-387-add-bar-chart-to-rollup branch from 3a569af to b6e14e9 Compare August 25, 2022 12:10
@gjvoosten gjvoosten merged commit 31adc62 into main Aug 25, 2022
@gjvoosten gjvoosten deleted the AB-387-add-bar-chart-to-rollup branch August 25, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

Assignees

@anilsonmez-simsoft anilsonmez-simsoft

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilsonmez-simsoft @gjvoosten