Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing deprecated fields #3982

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Allow editing deprecated fields #3982

merged 1 commit into from
Mar 9, 2022

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Mar 7, 2022 •
edited by gjvoosten
Loading

Deprecated fields can be edited if they have a value. Field disappears when the value is cleared, and then its value can no longer be set.

Closes AB#321

User changes

  • Users can edit deprecated field values if they were previously set.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@anilsonmez-simsoft anilsonmez-simsoft self-assigned this Mar 7, 2022
@anilsonmez-simsoft anilsonmez-simsoft changed the title AB#321: Allow editing deprecated fields Allow editing deprecated fields Mar 7, 2022
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-321-allow-editing-deprecated-fields branch from 9e8eed2 to b49a603 Compare March 7, 2022 08:18
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-321-allow-editing-deprecated-fields branch from b49a603 to fbbd115 Compare March 9, 2022 08:06
@anilsonmez-simsoft
AB#321: Allow editing deprecated fields
30e8dda 
Deprecated fields can be edited if they have a value.
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the AB-321-allow-editing-deprecated-fields branch from fbbd115 to 30e8dda Compare March 9, 2022 11:57
@gjvoosten gjvoosten merged commit 61fbff2 into main Mar 9, 2022
@gjvoosten gjvoosten deleted the AB-321-allow-editing-deprecated-fields branch March 9, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@midmarch midmarch Awaiting requested review from midmarch

Assignees

@anilsonmez-simsoft anilsonmez-simsoft

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilsonmez-simsoft @gjvoosten