Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span biography over 2 columns in people (person) page #3953

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Span biography over 2 columns in people (person) page #3953

merged 1 commit into from
Feb 14, 2022

Conversation

midmarch
Copy link
Contributor

@midmarch midmarch commented Feb 1, 2022 •
edited
Loading

Resolves AB#322

Requires dictionary change to activate:

Example to enable spanning the biography over 2 columns:

fields:
  advisor:
   person:
     showAsFullWidthFields: // new
       - biography
  principal:
   person:
     showAsFullWidthFields:  // new
       - biography

It is required that the fields are also listed under fields.person.advisor.showPageOrderedFields & fields.person.principal.showPageOrderedFields!

@midmarch
Copy link
Contributor Author

midmarch commented Feb 1, 2022

localhost_3000_people_828cb8e3-ce17-4d47-8919-33098970cd40

gjvoosten
gjvoosten requested changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

client/src/pages/people/Show.js Outdated Show resolved Hide resolved
client/src/pages/people/Show.js Outdated Show resolved Hide resolved
@midmarch midmarch force-pushed the span-biography-over-2-columns branch from 5b22bc7 to 45d4499 Compare February 2, 2022 09:29
gjvoosten
gjvoosten requested changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing.

anet-dictionary.yml Show resolved Hide resolved
client/src/models/Person.js Outdated Show resolved Hide resolved
@midmarch midmarch force-pushed the span-biography-over-2-columns branch 2 times, most recently from 55af844 to 5852f50 Compare February 2, 2022 16:54
@midmarch midmarch requested a review from gjvoosten February 7, 2022 09:07
@midmarch midmarch force-pushed the span-biography-over-2-columns branch from 5852f50 to c28ab96 Compare February 14, 2022 10:55
@midmarch midmarch merged commit 8c046f0 into main Feb 14, 2022
@midmarch midmarch deleted the span-biography-over-2-columns branch February 14, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@VassilIordanov VassilIordanov Awaiting requested review from VassilIordanov

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midmarch @gjvoosten