Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniquely identify assessments in the dictionary by key #3936

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Dec 1, 2021

Assessments in the dictionary had no key, which meant at most one definition for each recurrence type was possible. Now they have a key that uniquely identifies them, which in future would allow multiple assessment definitions with the same recurrence, e.g. several ondemand assessments.

Closes AB#296

User changes

  • None

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    If the dictionary previously contained e.g.:
    fields:
      task:
        subLevel:
          assessments:
            - recurrence: monthly
              questions:
                …
    
    this must now become:
    fields:
      task:
        subLevel:
          assessments:
            subTaskMonthly:
              recurrence: monthly
              questions:
                …
    
    Carefully update all assessment definitions, and give each a unique (and meaningful) key.
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten merged commit 28a95c5 into candidate Dec 2, 2021
@gjvoosten gjvoosten deleted the AB-296-assessments-as-object branch December 2, 2021 08:50
@gjvoosten gjvoosten mentioned this pull request Dec 23, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants