Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name conflict while importing bootstrap component #3933

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Nov 26, 2021

Closes AB#295

User changes

  • None

Super User changes

  • Super users can see the warning when trying to inactivate a filled position without the page crashing

Admin changes

  • Admins can see the warning when trying to inactivate a filled position without the page crashing

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten added the bug label Nov 29, 2021
@gjvoosten gjvoosten merged commit a93db91 into candidate Nov 29, 2021
@gjvoosten gjvoosten deleted the AB-295-fix-inactivating-filled-position branch November 29, 2021 07:36
@gjvoosten gjvoosten added debt and removed bug labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants