Remove task custom fields assessments #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are now in the dictionary and no longer in customFields.assessments.
Put schema in line with the current client-side aggregation implementation. Note that not all combinations of aggregationType and widget will lead to results.
gjvoosten
force-pushed
the
AB-294-remove-task-customFields-assessments
branch
from
c52e3a9 to
5d93b2b
Compare
Update test data and expected results, and remove obsolete test. Also update test dictionary with recent changes in the main dictionary.
gjvoosten
force-pushed
the
AB-294-remove-task-customFields-assessments
branch
from
5d93b2b to
c43221f
Compare
gjvoosten
requested review from
anilsonmez-simsoft,
midmarch,
asafkaganbezgin and
ny-simsoft
anilsonmez-simsoft
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tasks, assessments could either be defined through the dictionary or through a custom field
assessments. That second option has now been removed. Any previously existing assessment definitions through that second option should be moved to the dictionary.Closes AB#294
User changes
Super User changes
Admin changes
System admin changes
If any tasks had assessment definitions through a custom field, those should be moved to the dictionary. The custom field definition for task assessments (
fields.task.customFields.assessments) should then be removed from the dictionary.Checklist
repo#issue: Titletitle format and these 7 rules