Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace react svg text #3886

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Replace react svg text #3886

merged 2 commits into from
Oct 7, 2021

Conversation

anilsonmez-simsoft
Copy link
Contributor

react-svg-text dependency is removed and new functional component is implemented for the same purpose.

Closes #3885

User changes

  • None

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten merged commit 24ad031 into candidate Oct 7, 2021
@gjvoosten gjvoosten deleted the GH-3885-replace-react-svg-text branch October 7, 2021 13:42
@gjvoosten gjvoosten added the debt label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

Assignees
No one assigned
Labels
debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace react-svg-text
2 participants
@anilsonmez-simsoft @gjvoosten