Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify how principal sub-organization's are displayed #3512

Conversation

asafkaganbezgin
Copy link
Contributor

@asafkaganbezgin asafkaganbezgin commented Mar 25, 2021

Closes #363

User changes

  • When a principal organization has subordinate organizations, modify how the subordinate organizations are displayed in the parent organization's page.
    Previous display: Short Name Loooooooooooooooooooooooooooooooooong Name 123456
    New display: Short Name \ UIC: 123456
  • When displaying the parent organization of the subordinate organization, the new display is used.

Super User changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

client/src/pages/organizations/Show.js Outdated Show resolved Hide resolved
client/src/pages/organizations/Show.js Outdated Show resolved Hide resolved
@asafkaganbezgin asafkaganbezgin force-pushed the GH-363-modify-how-principal-sub-organizations-are-displayed branch from 89ef50f to e9aee42 Compare March 29, 2021 08:17
@asafkaganbezgin asafkaganbezgin changed the title NCI-Agency/anet#363: Modify how principal sub-organization's are disp… Modify how principal sub-organization's are displayed Mar 29, 2021
@gjvoosten
Copy link
Collaborator

  • When a principal organization has subordinate organizations, modify how the subordinate organizations are displayed in the parent organization's page.

@asafkaganbezgin Please specify how it has changed, i.e. what does the user see now?

client/src/pages/organizations/Show.js Outdated Show resolved Hide resolved
@asafkaganbezgin asafkaganbezgin force-pushed the GH-363-modify-how-principal-sub-organizations-are-displayed branch from e9aee42 to b4bbd6e Compare March 30, 2021 12:25
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asafkaganbezgin Approved, provided you update the PR description as requested.

@gjvoosten gjvoosten dismissed anilsonmez-simsoft’s stale review March 30, 2021 13:59

comments have been addressed

@gjvoosten gjvoosten merged commit 0ab13a9 into candidate Mar 30, 2021
@gjvoosten gjvoosten deleted the GH-363-modify-how-principal-sub-organizations-are-displayed branch March 30, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify How Principal Sub-Organization's are Displayed
3 participants