Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show absolute date/time on notes instead of relative #3505

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

gjvoosten
Copy link
Collaborator

Previously, notes in the side-panel would show a relative date/time such as "4 hours ago". Now, the date/time is shown as absolute (formatted as defined in the dictionary by the dateFormats.forms.displayShort.withTime key), e.g. "23 March 2021 @ 09:34".

Closes #3501

User changes

  • Notes in the side-panel are now shown with an absolute date/time.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten merged commit da5ff75 into candidate Mar 23, 2021
@gjvoosten gjvoosten deleted the GH-3501-show-absolute-date-on-notes branch March 23, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assessment date to old-style partner assessments
2 participants