Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a back to draft capability for published reports #3496

Merged

Conversation

anilsonmez-simsoft
Copy link
Contributor

@anilsonmez-simsoft anilsonmez-simsoft commented Mar 17, 2021

Admins now can unpublish reports from the client-side using the Unpublish Report button at the bottom of the report page. This function needs to be enabled in the anet-dictionary.yml by setting canUnpublishReports to true.

Closes #3480

User changes

  • none

Super User changes

  • none

Admin changes

  • If enabled in the dictionary, admins can unpublish (i.e. put back to draft) published reports.
  • Note that admins can now also manually publish future engagement reports that have been approved (previously they couldn't, and these would only get automatically published after the quarantine period).

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    If admins should be able to unpublish reports, add this setting to the dictionary:
    fields:
      report:
        canUnpublishReports: true
    
  • db needs migration
  • documentation has changed
  • graphql schema has changed
    There's a new GraphQL mutation, unpublishReport

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@cemalettin-work cemalettin-work marked this pull request as draft March 17, 2021 07:54
@cemalettin-work cemalettin-work changed the title Gh 3480 add a back to draft capability for published reports Add a back to draft capability for published reports Mar 17, 2021
@gjvoosten gjvoosten force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch from f0ee4d3 to 7bc12fe Compare March 17, 2021 11:01
@gjvoosten gjvoosten force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch 2 times, most recently from fdf6ed9 to c957050 Compare March 17, 2021 13:01
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch 2 times, most recently from 26dcd2d to 1cb4343 Compare March 22, 2021 06:34
anet-dictionary.yml Outdated Show resolved Hide resolved
@gjvoosten gjvoosten force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch 6 times, most recently from 6618c3f to 17fe809 Compare March 30, 2021 13:22
@gjvoosten gjvoosten force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch 2 times, most recently from 7178da8 to 5962053 Compare April 7, 2021 11:15
@gjvoosten gjvoosten force-pushed the GH-3480-add-a-back-to-draft-capability-for-published-reports branch from 5962053 to d94cb3c Compare April 12, 2021 11:14
@gjvoosten gjvoosten marked this pull request as ready for review April 12, 2021 13:18
@gjvoosten gjvoosten merged commit af364cd into candidate Apr 14, 2021
@gjvoosten gjvoosten deleted the GH-3480-add-a-back-to-draft-capability-for-published-reports branch April 14, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a back to draft capability for published reports
5 participants