-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a back to draft capability for published reports #3496
Merged
gjvoosten
merged 11 commits into
candidate
from
GH-3480-add-a-back-to-draft-capability-for-published-reports
Apr 14, 2021
Merged
Add a back to draft capability for published reports #3496
gjvoosten
merged 11 commits into
candidate
from
GH-3480-add-a-back-to-draft-capability-for-published-reports
Apr 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemalettin-work
changed the title
Gh 3480 add a back to draft capability for published reports
Add a back to draft capability for published reports
Mar 17, 2021
gjvoosten
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
from
March 17, 2021 11:01
f0ee4d3
to
7bc12fe
Compare
gjvoosten
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
2 times, most recently
from
March 17, 2021 13:01
fdf6ed9
to
c957050
Compare
anilsonmez-simsoft
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
2 times, most recently
from
March 22, 2021 06:34
26dcd2d
to
1cb4343
Compare
gjvoosten
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
6 times, most recently
from
March 30, 2021 13:22
6618c3f
to
17fe809
Compare
gjvoosten
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
2 times, most recently
from
April 7, 2021 11:15
7178da8
to
5962053
Compare
Change this into a more generic ConfirmDestructive component.
Also add display in the client-side workflow. Remove obsolete/inaccurate comment.
Change the location of canUnpublishReport property in anet-dictionary.yml file
…er of rows modified
gjvoosten
force-pushed
the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
from
April 12, 2021 11:14
5962053
to
d94cb3c
Compare
gjvoosten
requested review from
MehmetAli-Simsoft,
asafkaganbezgin and
midmarch
April 12, 2021 13:19
MehmetAli-Simsoft
approved these changes
Apr 14, 2021
asafkaganbezgin
approved these changes
Apr 14, 2021
gjvoosten
deleted the
GH-3480-add-a-back-to-draft-capability-for-published-reports
branch
April 14, 2021 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins now can unpublish reports from the client-side using the Unpublish Report button at the bottom of the report page. This function needs to be enabled in the
anet-dictionary.yml
by settingcanUnpublishReports
totrue
.Closes #3480
User changes
Super User changes
Admin changes
System admin changes
If admins should be able to unpublish reports, add this setting to the dictionary:
There's a new GraphQL mutation,
unpublishReport
Checklist
repo#issue: Title
title format and these 7 rules